feat: Implement BinaryenModuleUpdateMaps in js api.#8123
Merged
kripken merged 2 commits intoWebAssembly:mainfrom Dec 18, 2025
Merged
feat: Implement BinaryenModuleUpdateMaps in js api.#8123kripken merged 2 commits intoWebAssembly:mainfrom
BinaryenModuleUpdateMaps in js api.#8123kripken merged 2 commits intoWebAssembly:mainfrom
Conversation
This implements `BinaryenModuleUpdateMaps` as `module.update_maps()` in the js api. I might need some guidance on testing this. This is meant to be called after `setName` on a module in the c test suite it's called after `Table.setName` however I can't find any `setName` api's implemented in the js api so this might need to wait. I am trying to update this so we can make our bindings symmetrical between our js and c bindings in [`binaryen.ml`](grain-lang/binaryen.ml#266)
kripken
reviewed
Dec 15, 2025
Member
Yes, without the ability to rename things in the module maps (which are then read by |
Contributor
Author
|
I made that requested change, it seems weird to me that the api mixes |
kripken
approved these changes
Dec 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implements
BinaryenModuleUpdateMapsasmodule.update_maps()in the js api.I might need some guidance on testing this. This is meant to be called after
setNameon a module in the c test suite it's called afterTable.setNamehowever I can't find anysetNameapi's implemented in the js api so this might need to wait.I am trying to update this so we can make our bindings symmetrical between our js and c bindings in
binaryen.ml